[PATCH] D16383: Change ConstantFoldInstOperands to take Instruction instead of opcode and type. NFC.

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 13:33:49 PST 2016



On 02/09/2016 01:28 PM, Daniel Berlin wrote:
> Hey Manuel,
> Will you have time to address these issues?
>
> If not, i'm tempted to revert this set of changes.
> While I agree with your end goals of supporting the pointer type 
> changes,, right now i see unaddressed issues with this particular 
> implementation
> As I'm sure you know, comments and issues in reviews after commit need 
> to be addressed the same as pre-commit reviews and it's been about 2 
> weeks.
> .
> So if you won't have time to tackle this, that's fine, but we should 
> just probably revert it until you (or someone else) does have the time 
> to tackle this :)
>
> --Dan
+1


More information about the llvm-commits mailing list