[PATCH] D16312: [TableGen] Add 'register alternative name matching' support
Hal Finkel via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 2 22:03:25 PST 2016
hfinkel added a subscriber: hfinkel.
hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision is now accepted and ready to land.
Minor formatting issues, otherwise LGTM.
================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:2239
@@ +2238,3 @@
+
+ for(auto AltName : AltNames) {
+ AltName = StringRef(AltName).trim();
----------------
Insert white space after for.
================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:2243
@@ +2242,3 @@
+ // don't handle empty alternative names
+ if(AltName.empty())
+ continue;
----------------
Insert white space after `if`
================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:2790
@@ -2758,1 +2789,3 @@
+ if (AsmParser->getValueAsBit("ShouldEmitMatchRegisterAltName")) {
+ emitMatchRegisterAltName(Target, AsmParser, OS);
----------------
Remove {}.
http://reviews.llvm.org/D16312
More information about the llvm-commits
mailing list