[PATCH] D16590: Refactor backend diagnostics for unsupported features

Oliver Stannard via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 05:58:10 PST 2016


I've re-committed this as r259498 and r259499 with Matt's suggested
change. Only the BPF backend makes use of the option to supply an
SDValue, so I've put the code to append it to the message there.

Oliver

On 28 January 2016 at 19:09, Matt Arsenault via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> arsenm added inline comments.
>
> ================
> Comment at: llvm/trunk/include/llvm/IR/DiagnosticInfo.h:596
> @@ +595,3 @@
> +  const Twine &Msg;
> +  const SDValue Value;
> +
> ----------------
> Why can't this include the emitted message?
>
> You can then include a wrapper for this in codegen that accepts the SDValue
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D16590
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list