[PATCH] D16684: [ARM] Emit trap instruction using .inst directive

[James Molloy via llvm-commits]

Apologies, I'm not sure how I missed that when I read it last night. I was
convinced he was just removing the check without adding another.

LGTM!
On Fri, 29 Jan 2016 at 10:51, Renato Golin <renato.golin at linaro.org> wrote:

> On 29 January 2016 at 10:37, James Molloy <james at jamesmolloy.co.uk> wrote:
> > Hi,
> >
> > I'm not happy with the test changes; it was checking that at least the
> > comment said 'trap' - what happens now if we regress and the .inst is t
> even
> > emitted for that testcase?
>
> Hi James,
>
> He's testing for the .inst being emitted instead... Isn't that what we
> need?
>
> cheers,
> --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160129/4a2d196c/attachment.html>