[PATCH] D16712: [LoopVectorizer/LoopVersioning] Annotate versioned loop with noalias metadata

[Adam Nemet via llvm-commits]

anemet created this revision.
anemet added reviewers: hfinkel, nadav, ashutosh.nema.
anemet added subscribers: mcrosier, llvm-commits.
Herald added a subscriber: aemerson.

If we decide to version a loop to benefit a transformation, it makes
sense to record the now non-aliasing accesses in the newly versioned
loop.  This allows non-aliasing information to be used by subsequent
passes.

One example is 456.hmmer in SPECint2006 where after loop distribution,
we vectorize one of the newly distributed loops.  To vectorize we
version this loop to fully disambiguate may-aliasing accesses.  If we
add the noalias markers, we can use the same information in a later DSE
pass to eliminate some dead stores which amounts to ~25% of the
instructions of this hot memory-pipeline-bound loop.  The overall
performance improves by 18% on our ARM64.

The scoped noalias annotation is added in LoopVersioning.  The patch
then enables this for the vectorizer.  Other current users of
LoopVersioning will be enabled separately but first I'd like to get some
feedback whether my understanding and application of scoped noalias
metadata is correct.

Essentially my approach was to have a separate alias domain for each
versioning of the loop.  For example, if we first version in loop
distribution and then in vectorization of the distributed loops, we have
a different set of memchecks for each versioning.  By keeping the scopes
in different domains they can conveniently be defined independently
since different alias domains don't affect each other.

As written, I also have a separate domain for each loop.  This is not
necessary and we could save some metadata here by using the same domain
across the different loops.  I don't think it's a big deal either way.

Probably the best is to review the tests first to see if I mapped this
problem correctly to scoped noalias markers.  I have plenty of comments
in the tests.

Also currently, we only have an AA-aware DSE after the vectorizer if we
also run the LTO pipeline.  Depending how widely this triggers we may
want to schedule a DSE toward the end of the regular pass pipeline.

http://reviews.llvm.org/D16712

Files:
  include/llvm/Transforms/Utils/LoopVersioning.h
  lib/Transforms/Scalar/LoopDistribute.cpp
  lib/Transforms/Utils/LoopVersioning.cpp
  lib/Transforms/Vectorize/LoopVectorize.cpp
  test/Transforms/LoopVersioning/noalias-version-twice.ll
  test/Transforms/LoopVersioning/noalias.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16712.46358.patch
Type: text/x-patch
Size: 12665 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160129/8e5ce524/attachment.bin>