[PATCH] D16636: [ScheduleDAGInstrs] Make a conservative assumption about MIs with multiple MMOs.

[Chad Rosier via llvm-commits]

Thanks for the advice, Andy.  I suspect this will address the issue I'm seeing, but I wasn't able to actually test because the patch didn't apply cleanly to top of trunk.  Once D8705 lands I'll verify the issue has been fixed.

-----Original Message-----
From: Andrew Trick [mailto:atrick at apple.com] 
Sent: Wednesday, January 27, 2016 1:23 PM
To: mcrosier at codeaurora.org; matze at braunis.de; hfinkel at anl.gov; atrick at apple.com
Cc: listmail at philipreames.com; amara.emerson at arm.com; gberry at codeaurora.org; llvm-commits at lists.llvm.org
Subject: Re: [PATCH] D16636: [ScheduleDAGInstrs] Make a conservative assumption about MIs with multiple MMOs.

atrick added a comment.

The DAG builder should already conservatively handle multiple mem operands. If that's broken we don't want to hide the bug here. You're enabling AA, right? MIsNeedChangeEdge should handle it conservatively.

// FIXME: Need to handle multiple memory operands to support all targets.

  if (!MIa->hasOneMemOperand() || !MIb->hasOneMemOperand())
    return true;

Make sure you're not hitting the same bug that is fixed here:
http://reviews.llvm.org/D8705


http://reviews.llvm.org/D16636