[PATCH] D16636: [ScheduleDAGInstrs] Make a conservative assumption about MIs with multiple MMOs.

Andrew Trick via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 10:23:26 PST 2016


atrick added a comment.

The DAG builder should already conservatively handle multiple mem operands. If that's broken we don't want to hide the bug here. You're enabling AA, right? MIsNeedChangeEdge should handle it conservatively.

// FIXME: Need to handle multiple memory operands to support all targets.

  if (!MIa->hasOneMemOperand() || !MIb->hasOneMemOperand())
    return true;

Make sure you're not hitting the same bug that is fixed here:
http://reviews.llvm.org/D8705


http://reviews.llvm.org/D16636





More information about the llvm-commits mailing list