[PATCH] D16463: [DAGCombiner] Don't add volatile or indexed stores to ChainedStores

[Junmo Park via llvm-commits]

flyingforyou retitled this revision from "[DAGCombiner] Check store node's value count before replaceStoreChain" to "[DAGCombiner]  Don't add volatile or indexed stores to ChainedStores".
flyingforyou updated the summary for this revision.
flyingforyou updated this revision to Diff 45841.
flyingforyou added a comment.

Addressed Matt's comments.

Chad, there are several examples about crash. Sorry for misunderstanding.

Junmo.


http://reviews.llvm.org/D16463

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  test/CodeGen/AArch64/aarch64-DAGCombine-findBetterNeighborChains-crash.ll

Index: test/CodeGen/AArch64/aarch64-DAGCombine-findBetterNeighborChains-crash.ll
===================================================================
--- /dev/null
+++ test/CodeGen/AArch64/aarch64-DAGCombine-findBetterNeighborChains-crash.ll
@@ -0,0 +1,28 @@
+; RUN: llc < %s -march=arm64
+; Make sure we are not crashing on this test.
+
+target datalayout = "e-m:e-i64:64-i128:128-n32:64-S128"
+target triple = "aarch64-unknown-linux-gnu"
+
+declare void @extern(i8*)
+
+; Function Attrs: argmemonly nounwind
+declare void @llvm.memset.p0i8.i64(i8* nocapture, i8, i64, i32, i1) #0
+
+; Function Attrs: nounwind
+define void @func(float* noalias %arg, i32* noalias %arg1, i8* noalias %arg2, i8* noalias %arg3) #1 {
+bb:
+  %tmp = getelementptr inbounds i8, i8* %arg2, i64 88
+  tail call void @llvm.memset.p0i8.i64(i8* noalias %arg2, i8 0, i64 40, i32 8, i1 false)
+  store i8 0, i8* %arg3
+  store i8 2, i8* %arg2
+  store float 0.000000e+00, float* %arg
+  %tmp4 = bitcast i8* %tmp to <4 x float>*
+  store <4 x float> zeroinitializer, <4 x float>* %tmp4
+  store i32 5, i32* %arg1
+  tail call void @extern(i8* %tmp)
+  ret void
+}
+
+attributes #0 = { argmemonly nounwind }
+attributes #1 = { nounwind "target-cpu"="cortex-a53" }
Index: lib/CodeGen/SelectionDAG/DAGCombiner.cpp
===================================================================
--- lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -14760,7 +14760,8 @@
     while (true) {
       if (StoreSDNode *STn = dyn_cast<StoreSDNode>(NextInChain)) {
         // We found a store node. Use it for the next iteration.
-        ChainedStores.push_back(STn);
+        if (!STn->isVolatile() && STn->isUnindexed())
+          ChainedStores.push_back(STn);
         Index = STn;
         break;
       } else if (LoadSDNode *Ldn = dyn_cast<LoadSDNode>(NextInChain)) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16463.45841.patch
Type: text/x-patch
Size: 1863 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160125/79999b18/attachment.bin>