[PATCH] D16463: [DAGCombiner] Check store node's value count before replaceStoreChain

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 23 22:04:15 PST 2016


arsenm added a comment.

This isn't exactly the right way to fix this. The problem is this is trying to perform this for an indexed store, which was supposed to be skipped, so it should never end up in the ChainedStores list.

The loop in findBetterNeighborChains is supposed to mirror the logic in getStoreMergeAndAliasCandidates (and will hopefully eventually replace it), but it looks like it will add ChainedStores even for indexed. The first loop here is what should be fixed


http://reviews.llvm.org/D16463





More information about the llvm-commits mailing list