[PATCH] D16357: X86 processors and features

[Elena Demikhovsky via llvm-commits]

delena marked an inline comment as done.
delena added a comment.

Thanks everybody for the review.


================
Comment at: ../test/CodeGen/X86/avx512bw-intrinsics.ll:2914
@@ +2913,3 @@
+; AVX512F-32-LABEL: test_int_x86_avx512_mask_psrl_wi_512:
+; AVX512F-32:       # BB#0:
+; AVX512F-32-NEXT:    kmovd {{[0-9]+}}(%esp), %k1
----------------
kbsmith1 wrote:
> It seems unfortunate that the whole output of the routine needs to be duplicated for these two different checks.  It looks like only the form of the label, and the input of the kmovd are different between the newly added checks, and the AVX512BW versions, and that seems to apply to most all of the additions in this file.
This is an automatic tool that generates these checks. It does not understand that the diff is minor. We check the both 64 and 32 modes, because we have a special lowering for i64 values in 32-bit mode.


http://reviews.llvm.org/D16357