[PATCH] D16357: X86 processors and features

[Kevin B. Smith via llvm-commits]

kbsmith1 added a comment.

Two nits.  Up to you whether they are worth changing.  Either way LGTM.


================
Comment at: ../lib/Support/Host.cpp:822
@@ -815,3 +821,3 @@
   // Enable protection keys
   Features["pku"]    = HasLeaf7 && ((ECX >> 4) & 1);
 
----------------
Seems like it would be nice to move this (821,822) down to after line 835 so that all the ones dependent on ECX could be together.

================
Comment at: ../test/CodeGen/X86/avx512bw-intrinsics.ll:2914
@@ +2913,3 @@
+; AVX512F-32-LABEL: test_int_x86_avx512_mask_psrl_wi_512:
+; AVX512F-32:       # BB#0:
+; AVX512F-32-NEXT:    kmovd {{[0-9]+}}(%esp), %k1
----------------
It seems unfortunate that the whole output of the routine needs to be duplicated for these two different checks.  It looks like only the form of the label, and the input of the kmovd are different between the newly added checks, and the AVX512BW versions, and that seems to apply to most all of the additions in this file.


http://reviews.llvm.org/D16357