[lld] r257889 - Reapply r257753 with fix:

[Rafael Espíndola via llvm-commits]

Yes, asserts and llvm_unreachable are the right tools for finding out if
something changes.

Cheers,
Rafael
On Jan 21, 2016 5:03 AM, "George Rimar" <grimar at accesssoftek.com> wrote:

> >> +template <class ELFT>
> >> +void EhFrameHeader<ELFT>::assignEhFrame(EHOutputSection<ELFT> *Sec) {
> >> +  if (this->Sec && this->Sec != Sec) {
> >> +    warning("multiple .eh_frame sections not supported for
> .eh_frame_hdr");
> >> +    Live = false;
> >> +    return;
> >
> >Can this warning ever fire? If not it should be just an assert.
>
> In current code this should never be fired. I was just afraid about future
> changes, I am not sure about what can be done with linkerscript,
> for example and if it is possible to fire it. I think we can replace
> warning + "Live = false" with llvm_unreachable for now then, will it be ok ?
>
> >Cheers,
> >Rafael
>
> George.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160121/0e9f40a2/attachment.html>