[lld] r257889 - Reapply r257753 with fix:

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 02:03:17 PST 2016


>> +template <class ELFT>
>> +void EhFrameHeader<ELFT>::assignEhFrame(EHOutputSection<ELFT> *Sec) {
>> +  if (this->Sec && this->Sec != Sec) {
>> +    warning("multiple .eh_frame sections not supported for .eh_frame_hdr");
>> +    Live = false;
>> +    return;
>
>Can this warning ever fire? If not it should be just an assert.

In current code this should never be fired. I was just afraid about future changes, I am not sure about what can be done with linkerscript,
for example and if it is possible to fire it. I think we can replace warning + "Live = false" with llvm_unreachable for now then, will it be ok ?

>Cheers,
>Rafael

George.


More information about the llvm-commits mailing list