[PATCH] D16356: Color the background of sparklines on the daily report page based on the hash value of the binary.

Kristof Beyls via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 03:50:26 PST 2016


kristof.beyls updated this revision to Diff 45508.
kristof.beyls added a comment.

Ah yes, indeed the color selection logic fits much better in ui/util.py rather than analysis.py. Thanks for the pointer!
This updated patch has moved it to util.py and fixed the pep8 violations present in the original patch.


http://reviews.llvm.org/D16356

Files:
  lnt/server/reporting/dailyreport.py
  lnt/server/ui/templates/reporting/daily_report.html
  lnt/server/ui/util.py
  tests/SharedInputs/SmallInstance/data/lnt_db_create.sql
  tests/server/ui/Inputs/V4Pages_extra_records.sql
  tests/server/ui/V4Pages.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16356.45508.patch
Type: text/x-patch
Size: 15227 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160121/5aaf7436/attachment.bin>


More information about the llvm-commits mailing list