[PATCH] D16356: Color the background of sparklines on the daily report page based on the hash value of the binary.
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 20 17:30:21 PST 2016
MatzeB added a comment.
In http://reviews.llvm.org/D16356#331807, @MatzeB wrote:
> Isn't the only useful information here whether the binary has changed compared to the previous revision? Wouldn't it be better to just check for that and only alternate between two colors?
I just realized that you are exactly reusing a color (within a sparcline) iff the checksum is the same as a previous one, that makes sense and conveys extra information. So please ignore my previous comment :)
http://reviews.llvm.org/D16356
More information about the llvm-commits
mailing list