[PATCH] D16141: [TableGen] Fix sort order of asm operand classes

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 20 22:11:43 PST 2016


craig.topper added inline comments.

================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:267
@@ +266,3 @@
+  int getTreeDepth() const {
+    int depth = 0;
+    const ClassInfo *Root = this;
----------------
Variable names should be capitalized by coding standards.

================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:1596
@@ -1542,1 +1595,3 @@
+  }
+#endif
 }
----------------
Can we use std::is_sorted here and the location below?


http://reviews.llvm.org/D16141





More information about the llvm-commits mailing list