[PATCH] D15828: [PGO] Passmanagerbuilder change that enable IR level PGO instrumentation

[Rong Xu via llvm-commits]

You are right. I have this stmt here to avoid preinliner for non PGO
compilation. Now the preinliner is gone. I should have removed it. Thanks
for catching this. Will fix.

Rong
On Jan 20, 2016 6:15 PM, "Sean Silva" <chisophugis at gmail.com> wrote:

> silvas added inline comments.
>
> ================
> Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:204
> @@ +203,3 @@
> +void PassManagerBuilder::addPGOInstrPasses(legacy::PassManagerBase &MPM) {
> +  if (PGOInstrGen.empty() && PGOInstrUse.empty())
> +    return;
> ----------------
> One tiny nit I just saw: this check is redundant. The function does
> nothing if they are both empty because they are checked below individually.
>
>
> http://reviews.llvm.org/D15828
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160120/8eaf1740/attachment.html>