[PATCH] D15828: [PGO] Passmanagerbuilder change that enable IR level PGO instrumentation

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 20 18:15:44 PST 2016


silvas added inline comments.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:204
@@ +203,3 @@
+void PassManagerBuilder::addPGOInstrPasses(legacy::PassManagerBase &MPM) {
+  if (PGOInstrGen.empty() && PGOInstrUse.empty())
+    return;
----------------
One tiny nit I just saw: this check is redundant. The function does nothing if they are both empty because they are checked below individually.


http://reviews.llvm.org/D15828





More information about the llvm-commits mailing list