[PATCH] D16369: [AArch64] Don't drop MMOs in the load/store optimizer when forming ldp/stp instructions or pre-/post-index loads/stores.
Geoff Berry via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 20 12:53:30 PST 2016
gberry added inline comments.
================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1269
@@ -1267,2 +1268,3 @@
.addImm(Value);
+ MIB->setMemRefs(I->memoperands_begin(), I->memoperands_end());
} else {
----------------
For consistency, could you change this to drop the "MIB->" and just build off the above expr as was done in the change above?
================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1279
@@ -1276,2 +1278,3 @@
.addImm(Value / Scale);
+ MIB->setMemRefs(I->memoperands_begin(), I->memoperands_end());
}
----------------
Ditto
http://reviews.llvm.org/D16369
More information about the llvm-commits
mailing list