[llvm] r257857 - lli: use llvm::utostr() instead of std::to_string().

NAKAMURA Takumi via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 16:36:16 PST 2016


Committed in r258266.

On Wed, Jan 20, 2016 at 9:10 AM Hans Wennborg <hans at chromium.org> wrote:

> Yes, go ahead.
>
> On Tue, Jan 19, 2016 at 4:08 PM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
> > May I pull it into release_38? Cygwin (and a few, IIRC) doesn't have
> > std::to_string() and we have avoided one.
> >
> > 2016-01-15 11:14 GMT+09:00 NAKAMURA Takumi via llvm-commits
> > <llvm-commits at lists.llvm.org>:
> >> Author: chapuni
> >> Date: Thu Jan 14 20:14:46 2016
> >> New Revision: 257857
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=257857&view=rev
> >> Log:
> >> lli: use llvm::utostr() instead of std::to_string().
> >>
> >> Modified:
> >>     llvm/trunk/tools/lli/lli.cpp
> >>
> >> Modified: llvm/trunk/tools/lli/lli.cpp
> >> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lli/lli.cpp?rev=257857&r1=257856&r2=257857&view=diff
> >>
> ==============================================================================
> >> --- llvm/trunk/tools/lli/lli.cpp (original)
> >> +++ llvm/trunk/tools/lli/lli.cpp Thu Jan 14 20:14:46 2016
> >> @@ -16,6 +16,7 @@
> >>  #include "OrcLazyJIT.h"
> >>  #include "RemoteJITUtils.h"
> >>  #include "llvm/IR/LLVMContext.h"
> >> +#include "llvm/ADT/StringExtras.h"
> >>  #include "llvm/ADT/Triple.h"
> >>  #include "llvm/Bitcode/ReaderWriter.h"
> >>  #include "llvm/CodeGen/LinkAllCodegenComponents.h"
> >> @@ -741,11 +742,11 @@ std::unique_ptr<FDRPCChannel> launchRemo
> >>        ChildPath.reset(new char[ChildExecPath.size() + 1]);
> >>        std::copy(ChildExecPath.begin(), ChildExecPath.end(),
> &ChildPath[0]);
> >>        ChildPath[ChildExecPath.size()] = '\0';
> >> -      std::string ChildInStr = std::to_string(PipeFD[0][0]);
> >> +      std::string ChildInStr = utostr(PipeFD[0][0]);
> >>        ChildIn.reset(new char[ChildInStr.size() + 1]);
> >>        std::copy(ChildInStr.begin(), ChildInStr.end(), &ChildIn[0]);
> >>        ChildIn[ChildInStr.size()] = '\0';
> >> -      std::string ChildOutStr = std::to_string(PipeFD[1][1]);
> >> +      std::string ChildOutStr = utostr(PipeFD[1][1]);
> >>        ChildOut.reset(new char[ChildOutStr.size() + 1]);
> >>        std::copy(ChildOutStr.begin(), ChildOutStr.end(), &ChildOut[0]);
> >>        ChildOut[ChildOutStr.size()] = '\0';
> >>
> >>
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at lists.llvm.org
> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160120/aeb3586b/attachment.html>


More information about the llvm-commits mailing list