<div dir="ltr">Committed in r258266.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 20, 2016 at 9:10 AM Hans Wennborg <<a href="mailto:hans@chromium.org">hans@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yes, go ahead.<br>
<br>
On Tue, Jan 19, 2016 at 4:08 PM, NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>> wrote:<br>
> May I pull it into release_38? Cygwin (and a few, IIRC) doesn't have<br>
> std::to_string() and we have avoided one.<br>
><br>
> 2016-01-15 11:14 GMT+09:00 NAKAMURA Takumi via llvm-commits<br>
> <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>:<br>
>> Author: chapuni<br>
>> Date: Thu Jan 14 20:14:46 2016<br>
>> New Revision: 257857<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=257857&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=257857&view=rev</a><br>
>> Log:<br>
>> lli: use llvm::utostr() instead of std::to_string().<br>
>><br>
>> Modified:<br>
>>     llvm/trunk/tools/lli/lli.cpp<br>
>><br>
>> Modified: llvm/trunk/tools/lli/lli.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lli/lli.cpp?rev=257857&r1=257856&r2=257857&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lli/lli.cpp?rev=257857&r1=257856&r2=257857&view=diff</a><br>
>> ==============================================================================<br>
>> --- llvm/trunk/tools/lli/lli.cpp (original)<br>
>> +++ llvm/trunk/tools/lli/lli.cpp Thu Jan 14 20:14:46 2016<br>
>> @@ -16,6 +16,7 @@<br>
>>  #include "OrcLazyJIT.h"<br>
>>  #include "RemoteJITUtils.h"<br>
>>  #include "llvm/IR/LLVMContext.h"<br>
>> +#include "llvm/ADT/StringExtras.h"<br>
>>  #include "llvm/ADT/Triple.h"<br>
>>  #include "llvm/Bitcode/ReaderWriter.h"<br>
>>  #include "llvm/CodeGen/LinkAllCodegenComponents.h"<br>
>> @@ -741,11 +742,11 @@ std::unique_ptr<FDRPCChannel> launchRemo<br>
>>        ChildPath.reset(new char[ChildExecPath.size() + 1]);<br>
>>        std::copy(ChildExecPath.begin(), ChildExecPath.end(), &ChildPath[0]);<br>
>>        ChildPath[ChildExecPath.size()] = '\0';<br>
>> -      std::string ChildInStr = std::to_string(PipeFD[0][0]);<br>
>> +      std::string ChildInStr = utostr(PipeFD[0][0]);<br>
>>        ChildIn.reset(new char[ChildInStr.size() + 1]);<br>
>>        std::copy(ChildInStr.begin(), ChildInStr.end(), &ChildIn[0]);<br>
>>        ChildIn[ChildInStr.size()] = '\0';<br>
>> -      std::string ChildOutStr = std::to_string(PipeFD[1][1]);<br>
>> +      std::string ChildOutStr = utostr(PipeFD[1][1]);<br>
>>        ChildOut.reset(new char[ChildOutStr.size() + 1]);<br>
>>        std::copy(ChildOutStr.begin(), ChildOutStr.end(), &ChildOut[0]);<br>
>>        ChildOut[ChildOutStr.size()] = '\0';<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>