[PATCH] D15034: TargetLowering: Improve handling of (setcc ([sz]ext x) 0, cc) in SimplifySetCC
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 15 10:44:29 PST 2016
tstellarAMD added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:1248
@@ +1247,3 @@
+ if (VT == MVT::i1)
+ return N->isOne();
+
----------------
arsenm wrote:
> I think this should be !N->isNull(). If you have a constant true i1, it is -1 for example.
isOne() and isAllOnesValue() both return true for i1 1.
http://reviews.llvm.org/D15034
More information about the llvm-commits
mailing list