[PATCH] D15034: TargetLowering: Improve handling of (setcc ([sz]ext x) 0, cc) in SimplifySetCC
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 15 10:39:04 PST 2016
arsenm accepted this revision.
arsenm added a reviewer: arsenm.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM with that fixed
================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:1248
@@ +1247,3 @@
+ if (VT == MVT::i1)
+ return N->isOne();
+
----------------
I think this should be !N->isNull(). If you have a constant true i1, it is -1 for example.
http://reviews.llvm.org/D15034
More information about the llvm-commits
mailing list