[PATCH] D16144: NFC. Move getAlignment helper function from ValueTracking to Value class.

[Philip Reames via llvm-commits]

reames added a comment.

Given this code sometimes gets the ABI alignment and sometimes gets the preferred alignment, I'm not really clear on what the predicate actually is.  Unless you can write a clear bit of documentation which makes it obvious, I don't think this makes sense to promote to Value.


================
Comment at: include/llvm/IR/Value.h:505
@@ -502,3 +504,3 @@
   /// Sets CanBeNull if the pointer can be either dereferenceable or null
   bool isDereferenceablePointer(bool &CanBeNull) const;
 
----------------
It seems like this change might be based on something other than ToT.  I can't find this function in IR/Value.h in ToT.  Nor do I see it in the single listed dependency.


http://reviews.llvm.org/D16144