[PATCH] D16144: NFC. Move getAlignment helper function from ValueTracking to Value class.

Artur Pilipenko via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 01:34:51 PST 2016


apilipenko added a comment.

I'm going to move isDereferenceableAndAligned stuff from ValueTracking to Loads as Hal suggested in http://reviews.llvm.org/D10920. This functionality uses getAlignment static function which is also used by computeKnownBits machinery.

Why to Value class instead of making it a public ValueTracking function? It queries inherent properties of a Value just like isDereferenceable/getDereferenceableBytes I've introduced in http://reviews.llvm.org/D16116. All the three functions must be placed somewhere together, however I don't have strong preference about Value class being this place.


http://reviews.llvm.org/D16144





More information about the llvm-commits mailing list