[llvm] r257734 - Add virtual dtor

[David Blaikie via llvm-commits]

On Wed, Jan 13, 2016 at 6:10 PM, Xinliang David Li via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: davidxl
> Date: Wed Jan 13 20:10:49 2016
> New Revision: 257734
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257734&view=rev
> Log:
> Add virtual dtor
>
> Modified:
>     llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp
>
> Modified: llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp?rev=257734&r1=257733&r2=257734&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp (original)
> +++ llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp Wed Jan 13
> 20:10:49 2016
> @@ -313,6 +313,7 @@ struct CovMapFuncRecordReader {
>    // the module.
>    virtual std::error_code readFunctionRecords(const char *&Buf,
>                                                const char *End) = 0;
> +  virtual ~CovMapFuncRecordReader() {}
>

You could use "= default" here, if you like.


>    template <class IntPtrT, support::endianness Endian>
>    static std::unique_ptr<CovMapFuncRecordReader>
>    get(coverage::CoverageMappingVersion Version, InstrProfSymtab &P,
> @@ -340,6 +341,7 @@ public:
>        std::vector<BinaryCoverageReader::ProfileMappingRecord> &R,
>        std::vector<StringRef> &F)
>        : ProfileNames(P), Filenames(F), Records(R) {}
> +  ~VersionedCovMapFuncRecordReader() override {}
>

This line ^ is unnecessary. The default/implicit dtor will do the right
thing.


>
>    std::error_code readFunctionRecords(const char *&Buf,
>                                        const char *End) override {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160114/19b2d30a/attachment.html>