<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 13, 2016 at 6:10 PM, Xinliang David Li via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davidxl<br>
Date: Wed Jan 13 20:10:49 2016<br>
New Revision: 257734<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=257734&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=257734&view=rev</a><br>
Log:<br>
Add virtual dtor<br>
<br>
Modified:<br>
    llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp<br>
<br>
Modified: llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp?rev=257734&r1=257733&r2=257734&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp?rev=257734&r1=257733&r2=257734&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp (original)<br>
+++ llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp Wed Jan 13 20:10:49 2016<br>
@@ -313,6 +313,7 @@ struct CovMapFuncRecordReader {<br>
   // the module.<br>
   virtual std::error_code readFunctionRecords(const char *&Buf,<br>
                                               const char *End) = 0;<br>
+  virtual ~CovMapFuncRecordReader() {}<br></blockquote><div><br></div><div>You could use "= default" here, if you like.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   template <class IntPtrT, support::endianness Endian><br>
   static std::unique_ptr<CovMapFuncRecordReader><br>
   get(coverage::CoverageMappingVersion Version, InstrProfSymtab &P,<br>
@@ -340,6 +341,7 @@ public:<br>
       std::vector<BinaryCoverageReader::ProfileMappingRecord> &R,<br>
       std::vector<StringRef> &F)<br>
       : ProfileNames(P), Filenames(F), Records(R) {}<br>
+  ~VersionedCovMapFuncRecordReader() override {}<br></blockquote><div><br></div><div>This line ^ is unnecessary. The default/implicit dtor will do the right thing.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
   std::error_code readFunctionRecords(const char *&Buf,<br>
                                       const char *End) override {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>