[PATCH] D16110: [Power9] Implement new vsx instructions: quad-precision move, fp-arithmetic
Hal Finkel via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 12 17:09:21 PST 2016
hfinkel added inline comments.
================
Comment at: lib/Target/PowerPC/PPCSubtarget.cpp:95
@@ -94,2 +94,3 @@
IsE500 = false;
+ IsP9 = false;
FeatureMFTB = false;
----------------
Same here (move this up near the HasP8*).
================
Comment at: lib/Target/PowerPC/PPCSubtarget.h:114
@@ -113,2 +113,3 @@
bool IsPPC6xx;
+ bool IsP9;
bool FeatureMFTB;
----------------
Please move this up near HasP8* to keep things more-or-less semantically grouped.
================
Comment at: lib/Target/PowerPC/PPCSubtarget.h:245
@@ -243,2 +244,3 @@
bool isE500() const { return IsE500; }
+ bool isP9() const { return IsP9; }
bool isFeatureMFTB() const { return FeatureMFTB; }
----------------
Same here (move this up near the hasP8*()).
http://reviews.llvm.org/D16110
More information about the llvm-commits
mailing list