[PATCH] D16121: [test-suite] Fix exception caused by r256471.

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 12:59:55 PST 2016


MatzeB added a comment.

In http://reviews.llvm.org/D16121#325033, @delcypher wrote:

> @mcrosier
>
> It doesn't look like the `lit.cfg` in LLVM trunk and you have not uploaded much context in your diff so it took me a while to realise that this was `lit.cfg` in the `test-suite` repo.
>
> I didn't realise my change would effect the `test-suite` repo, sorry about that. I'm not familiar with this repo but is there a good reason that is using lit's internals instead of using it the normal way?


The test-suite has a few requirements that are different from a pure regression tests as in llvm core. The main difference today is that we have a split RUN: and VERIFY: lines so for example when cross compiling we know which part needs to be executed on the remote host, we can leave out the time spent in VERIFY: and only measure the RUN: part etc.

Nonetheless to actually implement these things we can reuse a bunch of the code in llvms lit, at the price that we sometimes have to adjust to llvm core changes.


http://reviews.llvm.org/D16121





More information about the llvm-commits mailing list