[PATCH] D16121: [test-suite] Fix exception caused by r256471.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 12:25:23 PST 2016


delcypher added a comment.

@mcrosier

It doesn't look like the `lit.cfg` in LLVM trunk and you have not uploaded much context in your diff so it took me a while to realise that this was `lit.cfg` in the `test-suite` repo.

I didn't realise my change would effect the `test-suite` repo, sorry about that. I'm not familiar with this repo but is there a good reason that is using lit's internals instead of using it the normal way?

As for the change itself, it seems reasonable but if you don't intend to use the `timeoutInfo` parameter you should probably just use `_` instead.


http://reviews.llvm.org/D16121





More information about the llvm-commits mailing list