[PATCH] D15950: [ARM] Fix several state persistence bugs

[Renato Golin via llvm-commits]

rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!


================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:1068
@@ +1067,3 @@
+  // do the same here
+  getAssembler().setELFHeaderEFlags(ELF::EF_ARM_EABI_VER5);
+}
----------------
loladiro wrote:
> rengolin wrote:
> > Can't this be changed by a command line flag? Shouldn't we clear based on that?
> I was basing this on https://github.com/llvm-mirror/llvm/blob/e5716c4e3ac95bb5f204390720af3a186814f2cb/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp#L1368, which looks unconditional to me. Is there a place where this gets reset later by a flag?
Hum, it seems not. Whenever someone worries about that, a quick search for EF_ARM_EABI_VER5 will bring them here, and the solution will be whatever it's used there, too.


http://reviews.llvm.org/D15950