[PATCH] D15950: [ARM] Fix several state persistence bugs
Keno Fischer via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 12 05:15:12 PST 2016
loladiro added inline comments.
================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:1068
@@ +1067,3 @@
+ // do the same here
+ getAssembler().setELFHeaderEFlags(ELF::EF_ARM_EABI_VER5);
+}
----------------
rengolin wrote:
> Can't this be changed by a command line flag? Shouldn't we clear based on that?
I was basing this on https://github.com/llvm-mirror/llvm/blob/e5716c4e3ac95bb5f204390720af3a186814f2cb/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp#L1368, which looks unconditional to me. Is there a place where this gets reset later by a flag?
http://reviews.llvm.org/D15950
More information about the llvm-commits
mailing list