[llvm] r257431 - OrcRemoteTargetServer.h: Suppress a warning. [-Wunused-variable]

[Lang Hames via llvm-commits]

Hi Takumi,

> FIXME: It may return ErrorOr.

This method will return into the JIT resolver block, and from there to
JIT'd user code, which can't be expected to know how to recover from a
failure to JIT.

I think the best we could do is, in cases where exceptions are turned on,
throw a JITException containing the error code. The user code could catch
that and deal with it if it knew how, and if not it would fall all the way
through to the original entry point from the JIT server. If we taught the
RPC how to serialize/deserialize ErrorOr then we could return that as the
result to the client.

- Lang.

On Mon, Jan 11, 2016 at 7:08 PM, David Blaikie <dblaikie at gmail.com> wrote:

>
>
> On Mon, Jan 11, 2016 at 5:23 PM, NAKAMURA Takumi via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: chapuni
>> Date: Mon Jan 11 19:23:43 2016
>> New Revision: 257431
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=257431&view=rev
>> Log:
>> OrcRemoteTargetServer.h: Suppress a warning. [-Wunused-variable]
>>
>> FIXME: It may return ErrorOr.
>>
>> Modified:
>>     llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h
>>
>> Modified:
>> llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h?rev=257431&r1=257430&r2=257431&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h
>> (original)
>> +++ llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h
>> Mon Jan 11 19:23:43 2016
>> @@ -156,6 +156,7 @@ private:
>>          CompiledFnAddr, static_cast<TargetAddress>(
>>
>>  reinterpret_cast<uintptr_t>(TrampolineAddr)));
>>      assert(!EC && "Compile request failed");
>> +    (void)&EC;
>>
>
> Could drop the '&' here
>
>
>>      return CompiledFnAddr;
>>    }
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160111/23942fbe/attachment.html>