<div dir="ltr">Hi Takumi,<div><br></div><div>> FIXME: It may return ErrorOr.</div><div><br></div><div>This method will return into the JIT resolver block, and from there to JIT'd user code, which can't be expected to know how to recover from a failure to JIT. <div class="gmail_extra"><br></div><div class="gmail_extra">I think the best we could do is, in cases where exceptions are turned on, throw a JITException containing the error code. The user code could catch that and deal with it if it knew how, and if not it would fall all the way through to the original entry point from the JIT server. If we taught the RPC how to serialize/deserialize ErrorOr then we could return that as the result to the client.</div><div class="gmail_extra"><br></div><div class="gmail_extra">- Lang.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 11, 2016 at 7:08 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Mon, Jan 11, 2016 at 5:23 PM, NAKAMURA Takumi via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: chapuni<br>
Date: Mon Jan 11 19:23:43 2016<br>
New Revision: 257431<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=257431&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=257431&view=rev</a><br>
Log:<br>
OrcRemoteTargetServer.h: Suppress a warning. [-Wunused-variable]<br>
<br>
FIXME: It may return ErrorOr.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h<br>
<br>
Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h?rev=257431&r1=257430&r2=257431&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h?rev=257431&r1=257430&r2=257431&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h (original)<br>
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h Mon Jan 11 19:23:43 2016<br>
@@ -156,6 +156,7 @@ private:<br>
         CompiledFnAddr, static_cast<TargetAddress>(<br>
                             reinterpret_cast<uintptr_t>(TrampolineAddr)));<br>
     assert(!EC && "Compile request failed");<br>
+    (void)&EC;<br></blockquote><div><br></div></span><div>Could drop the '&' here</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
     return CompiledFnAddr;<br>
   }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div></div></div>