[PATCH] D15472: [GlobalISel] ] Add a generic machine opcode for ADD.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 21:52:49 PST 2016


I like the third one, mostly for readability with the _

On Mon, Jan 11, 2016, 9:43 PM Owen Anderson <resistor at mac.com> wrote:

> I prefer #3.
>
> —Owen
>
> > On Jan 11, 2016, at 6:02 PM, Philip Reames via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
> >
> > Either (1) or (3) would be good.  (2) is ambiguous.
> >
> > Philip
> >
> > On 01/11/2016 04:41 PM, Quentin Colombet via llvm-commits wrote:
> >> qcolombet added a comment.
> >>
> >> So far we have three proposals for GISel opcodes, all of them got one
> vote:
> >>
> >> 1. g<opcode>, e.g., gADD
> >> 2. <opcode>, e.g., ADD
> >> 3. G_<opcode>, e.g., G_ADD
> >>
> >> Which one is your favorite?
> >>
> >> I am going to go for #1 if I do not get other vote to break the tie :).
> >>
> >> Cheers,
> >> -Quentin
> >>
> >>
> >> Repository:
> >>   rL LLVM
> >>
> >> http://reviews.llvm.org/D15472
> >>
> >>
> >>
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at lists.llvm.org
> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160112/151ba2ca/attachment.html>


More information about the llvm-commits mailing list