[PATCH] D15665: GlobalsAA: InaccessibleMemOnly does not mean ReadNone.

[Hal Finkel via llvm-commits]

hfinkel added a comment.

In http://reviews.llvm.org/D15665#320043, @reames wrote:

> Let me repeat my early comment in a slightly stronger form.  Unless you have strong evidence that this needs to be in GlobalsAA, please start by implementing this in BasicAA.  This will get you most of the properties you're looking for (value forwarding), without the complexity involved in GlobalAA.  In particular, teach getModRefInfo(CS, Location) about it.
>
> I also believe that the original GlobalAA patch should be reverted rather than patched in this manner.  It was flat out wrong.


I agree with Philip. We need to teach BasicAA about the attribute; only then, if necessary, should we teach GlobalsAA about it. Please revert the GlobalsAA patch, and then, propose a new clean patch for GlobalsAA, if necessary, after the BasicAA work is done.


http://reviews.llvm.org/D15665