[PATCH] D15665: GlobalsAA: InaccessibleMemOnly does not mean ReadNone.

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 14:36:32 PST 2016


reames added a comment.

Let me repeat my early comment in a slightly stronger form.  Unless you have strong evidence that this needs to be in GlobalsAA, please start by implementing this in BasicAA.  This will get you most of the properties you're looking for (value forwarding), without the complexity involved in GlobalAA.  In particular, teach getModRefInfo(CS, Location) about it.

I also believe that the original GlobalAA patch should be reverted rather than patched in this manner.  It was flat out wrong.


http://reviews.llvm.org/D15665





More information about the llvm-commits mailing list