[PATCH] D15383: [ELF] - R_386_GOTOFF relocation implemented.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: lld/trunk/ELF/Writer.cpp:214
@@ -212,1 +213,3 @@
+      HasGotOffRel = true;
+
     if (Target->isTlsLocalDynamicReloc(Type)) {
----------------
btw, what about making this more generic ?

1) Change HasGotOffRel to be not a global variable but a public member of target.
2) remove isGotRelative(Type), create visitRelocation(Type) or something alike instead. Which purpose would be to review relocation and set flags like HasGotOffRel inside.



Repository:
  rL LLVM

http://reviews.llvm.org/D15383