[PATCH] D15676: [attrs] Extract the pure inference of function attributes into a standalone pass.
James Molloy via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 21 02:06:15 PST 2015
jmolloy accepted this revision.
jmolloy added a comment.
This revision is now accepted and ready to land.
Hi Chandler,
Thanks for taking the time to do this.
I agree with Philip - while I like that you've added extra norecurse attributes, I don't like that it's smuggled in as part of this patch. I'd highly prefer this patch to be NFC and then a simple update patch adding the norecurse attributes.
Apart from that and the specific comment below, it LGTM.
Cheers,
James
================
Comment at: include/llvm/Transforms/IPO/InferFunctionAttrs.h:25
@@ +24,3 @@
+/// A pass which infers function attributes from the names and signatures of
+/// function declarations in a module..
+class InferFunctionAttrsPass {
----------------
Double period.
================
Comment at: include/llvm/Transforms/IPO/InferFunctionAttrs.h:26
@@ +25,3 @@
+/// function declarations in a module..
+class InferFunctionAttrsPass {
+public:
----------------
Unrelated: Damn, new style passes look so much nicer!
http://reviews.llvm.org/D15676
More information about the llvm-commits
mailing list