[PATCH] D15758: Split Defined and DefinedElf

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Symbols.h:152
@@ -144,3 +151,3 @@
   const Elf_Sym &Sym;
-  static bool classof(const SymbolBody *S) { return S->isDefined(); }
+  static bool classof(const SymbolBody *S) { return S->kind() <= SharedKind; }
 };
----------------
ruiu wrote:
> Ah, so you changed the order for this. But this maybe too subtle? I'd define DefinedElfLast enum and do `S->kind() <= DefinedElfLast` here.
I strongly agree here.


http://reviews.llvm.org/D15758