[PATCH] D15758: Split Defined and DefinedElf

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits.


================
Comment at: ELF/Symbols.h:63-64
@@ -63,3 +62,4 @@
     SharedKind,
-    DefinedLast = SharedKind,
+    DefinedSyntheticKind,
+    DefinedLast = DefinedSyntheticKind,
     UndefinedElfKind,
----------------
Why did you change the order?

================
Comment at: ELF/Symbols.h:140
@@ +139,3 @@
+
+// Any defined symbol from an elf file.
+template <class ELFT> class DefinedElf : public Defined {
----------------
elf -> ELF

================
Comment at: ELF/Symbols.h:152
@@ -144,3 +151,3 @@
   const Elf_Sym &Sym;
-  static bool classof(const SymbolBody *S) { return S->isDefined(); }
+  static bool classof(const SymbolBody *S) { return S->kind() <= SharedKind; }
 };
----------------
Ah, so you changed the order for this. But this maybe too subtle? I'd define DefinedElfLast enum and do `S->kind() <= DefinedElfLast` here.


http://reviews.llvm.org/D15758