[PATCH] D15553: PR25717: fatal IO error writing large outputs to console on Windows

Yaron Keren via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 14:40:34 PST 2015


yaron.keren added a comment.

+1 all general-purpose Windows stuff should move to WindowsSupport.h. I'm surprised we got away without so far. 
We have NOMINMAX at lib/Driver/MSVCToolChain.cpp before Windows.h which should probably switched to use WindowsSupport.h.


http://reviews.llvm.org/D15553





More information about the llvm-commits mailing list