[PATCH] D15553: PR25717: fatal IO error writing large outputs to console on Windows

[Aaron Ballman via llvm-commits]

aaron.ballman added inline comments.

================
Comment at: lib/Support/raw_ostream.cpp:61
@@ +60,3 @@
+#ifdef LLVM_ON_WIN32
+#define NOMINMAX
+#include "Windows/WindowsSupport.h"
----------------
I think this should be moved into WindowsSupport.h, truth be told. I don't think *anyone* wants min or max to be macros in this project.

================
Comment at: lib/Support/raw_ostream.cpp:67
@@ +66,3 @@
+// Cygwin does not have the IsWindows8OrGreater() API.
+static bool IsWindows8OrGreater() {
+  OSVERSIONINFO osvi = {};
----------------
Would it make sense to add the VersionHelpers.h include and IsWindows8OrGreater() to WindowsSupport.h as these seem like much more generally useful than just for raw_ostream?

I don't feel strongly about this, but am curious what others think.


http://reviews.llvm.org/D15553