[PATCH] D15622: AMDGPU: fix overlapping copies in copyPhysReg

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 07:25:50 PST 2015


tstellarAMD added inline comments.

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:433
@@ +432,3 @@
+    unsigned SubIdx;
+    if (DestReg <= SrcReg)
+      SubIdx = SubIndices[Idx];
----------------
You should use SIRegisterInfo::getHWRegIndex(unsigned Reg) here so we don't have to rely on the order of the enumerations.


http://reviews.llvm.org/D15622





More information about the llvm-commits mailing list