[PATCH] D14429: [mips][microMIPS][DSP] Implement PACKRL.PH, PICK.PH, PICK.QB, SHILO, SHILOV and WRDSP instructions

[Zlatko Buljan via llvm-commits]

zbuljan added inline comments.

================
Comment at: lib/Target/Mips/MipsInstrInfo.td:392
@@ +391,3 @@
+  let RenderMethod = "addImmOperands";
+  let ParserMethod = "parseImm";
+  let PredicateMethod = "isConstantSImm<" # Bits # ">";
----------------
dsanders wrote:
> Do you really need a ParserMethod? Integers should parse properly with the default parser.
I agree, ParserMethod is not needed here. I'll remove it from patch.


http://reviews.llvm.org/D14429