[PATCH] D14429: [mips][microMIPS][DSP] Implement PACKRL.PH, PICK.PH, PICK.QB, SHILO, SHILOV and WRDSP instructions

[Daniel Sanders via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with one change I missed last time.


================
Comment at: lib/Target/Mips/MipsInstrInfo.td:392
@@ +391,3 @@
+  let RenderMethod = "addImmOperands";
+  let ParserMethod = "parseImm";
+  let PredicateMethod = "isConstantSImm<" # Bits # ">";
----------------
Do you really need a ParserMethod? Integers should parse properly with the default parser.


http://reviews.llvm.org/D14429