[PATCH] D15483: [Polly] Unique value write accesses

[Tobias Grosser via llvm-commits]

grosser added a comment.

Hi Michael,

again a small self-contained patch with minimal test-case noise. Nice!

>From my side this patch looks good. Not only does it remove the redundant loads, but it also adds a mapping that will allow us to retrieve the scalar value writes of a scop statement, in case this functionality is needed later. This addresses Johannes concerns of us loosing parts of the Instruction->MemAccess mapping for value writes (and assuming we add such maps for other scalar accesses also in general).

Let's discuss this at the phone call tonight, but from my side this is commit ready.


================
Comment at: include/polly/ScopInfo.h:995
@@ +994,3 @@
+  /// @brief Return the MemoryAccess that writes the value of an instruction
+  ///        defined in this statement, or nullptr if not (yet) added.
+  MemoryAccess *lookupValueWriteOf(Instruction *Inst) const {
----------------
... or not existing.

================
Comment at: lib/Analysis/ScopInfo.cpp:3948
@@ -3930,2 +3947,3 @@
 }
+
 void ScopInfo::addValueReadAccess(Value *Value, Instruction *User) {
----------------
Unrelated. Please commit ahead of time.


http://reviews.llvm.org/D15483