[PATCH] D15531: Change linkInModule to take a std::unique_ptr

[whitequark via llvm-commits]

whitequark added a comment.

LGTM after changes described above.


================
Comment at: bindings/ocaml/linker/llvm_linker.mli:17
@@ -16,4 +16,3 @@
 
-(** [link_modules dst src mode] links [src] into [dst], raising [Error]
-    if the linking fails. *)
-val link_modules : Llvm.llmodule -> Llvm.llmodule -> unit
\ No newline at end of file
+(** [link_modules' dst src mode] links [src] into [dst], raising [Error]
+    if the linking fails. The src module is destroyed. *)
----------------
There's no mode argument anymore--the signature should read [link_modules' dst src].

================
Comment at: docs/ReleaseNotes.rst:87
@@ -83,3 +86,3 @@
 
  During this release ...
 
----------------
Can you please add a notice similar to the one about the C API above about the link_modules' function?


http://reviews.llvm.org/D15531