[PATCH] D15531: Change linkInModule to take a std::unique_ptr

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 17:04:08 PST 2015


echristo added a comment.

Couple of inline comments.


================
Comment at: include/llvm-c/Linker.h:39
@@ +38,3 @@
+ *
+ * This funciton is deprecated. Use LLVMLinkModules2 instead.
+ */
----------------
Typo.

================
Comment at: include/llvm-c/Linker.h:44
@@ -40,1 +43,3 @@
 
+LLVMBool LLVMLinkModules2(LLVMModuleRef Dest, LLVMModuleRef Src);
+
----------------
For now please document the changes between the two functions. It would probably be best if you do so in the release notes as well.


http://reviews.llvm.org/D15531





More information about the llvm-commits mailing list