[llvm] r255621 - Fix MSVC build with LLVM_ENABLE_THREADS=OFF

[Mehdi Amini via llvm-commits]

Sent from my iPhone

> On Dec 15, 2015, at 11:50 AM, Reid Kleckner <rnk at google.com> wrote:
> 
> I think I fixed that const qualified issue with r255678. I still have warnings from ppltasks.h, which is this connect issue:
> https://connect.microsoft.com/VisualStudio/feedback/details/1132688/ppltasks-h-does-not-compile-cleanly
> 
> I think we should ban inclusions of <future> in LLVM and make a wrapper header that uses pragmas to disable warnings in <future> transitive includes.

#include "llvm/Support/future.h"?
I can give a try at that later today, but since I can't validate with MSVC it might take a few tentatives, so I don't mind if someone else do it.

Thanks,

Mehdi

> 
>> On Tue, Dec 15, 2015 at 12:50 PM, Mehdi Amini via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> Oh ok you are talking about this one:
>> 
>>> C:\llvm\rw\include\llvm/Support/ThreadPool.h(73): error C3848: expression having type 'const std::_Bind<true,void,void (__cdecl *const )(std::atomic_int &,int),_Ty,size_t &>' would lose some const-volatile qualifiers in order to call 'void std::_Bind<true,void,void (__cdecl *const )(std::atomic_int &,int),_Ty,size_t &>::operator ()<>(void)'
>>> 1>          with
>> 
>> It was not clear in the sea of warning (probably because I'm used to Clang like warnings).
>> 
>> I'm away of the office right now, I'll try to look at it if you don't figure out, but no ETA.
>> 
>> Thanks,
>> 
>> Mehdi
>> 
>> 
>> 
>> Sent from my iPhone
>> 
>> On Dec 15, 2015, at 5:59 AM, Kuperstein, Michael M <michael.m.kuperstein at intel.com> wrote:
>> 
>>>> C:\llvm\rw\include\llvm/Support/ThreadPool.h(73): error C3848: expression having type 'const std::_Bind<true,void,void (__cdecl *const )(std::atomic_int &,int),_Ty,size_t &>' would lose some const-volatile qualifiers in order to call 'void std::_Bind<true,void,void (__cdecl *const )(std::atomic_int &,int),_Ty,size_t &>::operator ()<>(void)'
>>>> 1>          with
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151215/93cd3b68/attachment.html>